Changed settings dialog to an activity #1938
Conversation
|
I have only a phone with me, so it is difficult to read sources for me at this moment, but I am wondering if you took care of updating the main and details view too, like the on demand check box of the details view. I will wait with merging this until after releasing a new stable version in any case. I am glad you are contributing again! |
|
These changes are only for the settings dialog (main settings and app settings), I did not touch the detail view (yet 😉).
I don't understand... Do you think I should update the main and details views too? As you want for the merge, it could have been a nice feature to add to the last XPrivacy 2 release! |
|
What I mean is that some settings changes have effect in the main and details view, for example enabling or disabling on demand restricting. |
|
Everything looks okay, also the refresh of the application list and application details view: |
|
I just checked and it's alright: enabling/disabling on demand restricting updates the main/details view when you save the settings. |
Changed settings dialog to an activity
Showing action bar items always Remove passing application name Formatting Refs #1938
|
This is all good work, Tony! |
|
Thanks, I'm happy to contribute! |
This changes the settings dialog to an activity.
This removes the issue with the outdated title bar as well as a glitch in popup's white theme.
There are quite a lot of lines changed but I divided the changes into multiple commits, thankfully it will be easier to follow them.